Improve UPDATES query for Platform #2132
Open
+159
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| var results = new World[count]; | ||
|
|
||
| var ids = new int[count]; |
Member
There was a problem hiding this comment.
Given how small this array is, could we stackalloc it?
Member
Author
There was a problem hiding this comment.
Right here probably (I had tried on the update method at first), there is a MemoryExtensions method to do that on spans.
Member
Author
There was a problem hiding this comment.
Got confused by the diff but we can't do this in the updates scenario because we need to pass the ids array as a parameter.
Member
There was a problem hiding this comment.
Npgsql supports ReadOnlyMemory<byte> (and I think of char too?), though IIRC it doesn't support mapping arrays of arbitrary types via ROM - might be worth trying just in case I'm misremembering.
(ArrayPool sounds good if not!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.